fix serveStatic method #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait should this PR be merged in V2 branch.. ? |
|
@hironichu Thank you for your PR ! No worries, the V2 branch is obsolete, main branch is V2. Unfortunately, your fix indeed fix windows, but also break everything else 😢 I added a condition, if we're not on windows we prepend the / |
Sorikairox
force-pushed
the
fix/serveStatic
branch
from
ee1c3e0 to
a72ea7e
Compare
Sorikairox
force-pushed
the
fix/serveStatic
branch
from
a72ea7e to
e297ec2
Compare
Sorikairox
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a small issue running Danet on windows using the serveStatic method.
On windows when we use Deno.cwd() we get the full path of the OS starting with C:\...
This added a \ before C:\ which resolved in a invalid path :
/C:\Users\xxxx\Documents\Projects\xxxx/assets/manifest.jsonType of change
Checklist:
deno lintANDdeno fmtANDdeno task testand got noerrors.
in CONTRIBUTING.md
Pull Requests for the same
update/change?